8000 `exn` crosses portable and contended by riaqn · Pull Request #4062 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

exn crosses portable and contended #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2025
Merged

exn crosses portable and contended #4062

merged 9 commits into from
May 30, 2025

Conversation

riaqn
Copy link
Contributor
@riaqn riaqn commented May 29, 2025

This PR is a temporary workaround that allows exn to cross portability and contention. To make it safe:

  • Exception constructor is nonportable if any of its arguments is nonportable; as a result, it cannot be closed over by a portable function.
  • Exception constructor are always expected to be uncontended. It becomes contended inside a portable function, unless all the constructor arguments cross contention.

@riaqn riaqn force-pushed the portable-ext-types branch from de39830 to a4a1324 Compare May 29, 2025 13:39
@dkalinichenko-js dkalinichenko-js self-requested a review May 29, 2025 15:36
@riaqn riaqn force-pushed the portable-ext-types branch from 3da93d8 to e204596 Compare May 29, 2025 16:40
Copy link
Collaborator
@dkalinichenko-js dkalinichenko-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core change looks good.

Copy link
Collaborator
@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look at the tests

@riaqn riaqn requested a review from dkalinichenko-js May 30, 2025 09:48
Copy link
Collaborator
@dkalinichenko-js dkalinichenko-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@riaqn riaqn requested a review from dkalinichenko-js May 30, 2025 16:02
@riaqn riaqn changed the title exn crosses portable exn crosses portable and contended May 30, 2025
@riaqn riaqn enabled auto-merge (squash) May 30, 2025 16:03
@riaqn riaqn merged commit e1b776d into main May 30, 2025
28 checks passed
@riaqn riaqn deleted the portable-ext-types branch May 30, 2025 16:33
goldfirere added a commit that referenced this pull request May 30, 2025
goldfirere added a commit that referenced this pull request May 30, 2025
riaqn added a commit that referenced this pull request Jun 10, 2025
riaqn added a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0