Don't specialize %obj_field, %obj_setfield, and %obj_size
#4101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could learn more about this, but I don't feel comfortable here off-hand. Is this something @mshinwell can competently review? |
|
(Discussed with @ccasin, and he offered to review, so assigning him.) |
ccasin
approved these changes
Jun 24, 2025
rtjoa
added a commit
that referenced
this pull request
Jun 24, 2025
Don't specialize %obj_ primitives
rtjoa
added a commit
that referenced
this pull request
Jun 25, 2025
Don't specialize %obj_ primitives
rtjoa
added a commit
that referenced
this pull request
Jun 25, 2025
Don't specialize %obj_ primitives
rtjoa
added a commit
that referenced
this pull request
Jun 25, 2025
Don't specialize %obj_ primitives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primitives
%obj_field,%obj_setfield, and%obj_sizeall masquerade as array primitives, whose array type kinds are specialized. This never changes the obj primitives in practice, as they are never bound to array types.However, it's useful to stop specializing these primitives, as it allows us to add extra checks to array primitive specialization in the following PR. (Eventually, we should just make separate obj primitives for these in lambda, and a CR is left stating as such, but we'd like to get the following PR through.)
Stack
%obj_field,%obj_setfield, and%obj_size#4101Typeopt.array_type_kind: when element is non-value or unknown, error instead of defaulting toPgenvalue#4098