Refactor CI regalloc jobs. #4148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@mshinwell, you will need to update the list of |
b8383b3 to
3f3f725
Compare
|
(As of e9175fa, this pull request is |
gretay-js
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is refactoring the regalloc-related
CI jobs, to try and save some time.
Since we now have a
regalloc.exetool able to runonly the register allocation passes from artifacts, we
can factor out jobs testing IRC, Linscan, and Greedy
on a similar configuration. This is done through a
new optional CI step, which simply runs all 3 allocators
on the saved artifacts.
It is not the exact same thing as running a complete
build, because it will by definition not exercise the
consequences of register allocation on later passes.
However, it feels like a reasonable compromise.
I have also not maintained a strict 1:1 of CI jobs
(in part because I think some were leftovers of a
debugging session). At the time of writing, the
refactoring deletes 6 CI jobs.
(Currently using the
-debug-outputonly to manuallycheck that some work is indeed happening in the
new CI step.)