8000 Arm64: remove rosetta check by gretay-js · Pull Request #4178 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Arm64: remove rosetta check #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2025
Merged

Arm64: remove rosetta check #4178

merged 4 commits into from
Jun 25, 2025

Conversation

gretay-js
Copy link
Contributor

Test_helpers.run_if_not_under_rosetta2 doesn't do anything on amd64 (the check returns Unknown when I test it locally on an amd64 machine, and the checks don't run). Now that we have a separate arm64 implementation of these intrinsics, we can removed this check from both shared and amd64-only tests.

@gretay-js gretay-js requested a review from TheNumbat June 24, 2025 13:19
@gretay-js gretay-js added the simd SIMD support label Jun 24, 2025
@gretay-js gretay-js changed the title Arm64: remove rosseta check Arm64: remove rosetta check Jun 24, 2025
@gretay-js gretay-js marked this pull request as ready for review June 24, 2025 16:45
TheNumbat
TheNumbat approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@TheNumbat TheNumbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deleted test_helpers entirely since I don't think we care about testing on rosetta at all anymore

@mshinwell
Copy link
Collaborator

@xclerc tests on Rosetta, please discuss with him first.

@gretay-js
Copy link
Contributor Author

@xclerc tests on Rosetta, please discuss with him first.

The file @TheNumbat deleted is unused. If we need it again, we can restore it.

@xclerc
Copy link
Contributor
xclerc commented Jun 25, 2025

I have just checked that, with Rosetta2 on,
I get the same output for make ci before
and after this pull request.

There are a handful or failures, but they are
(i) the same and (ii) not related to the tests
this pull request touches.

(The failures are about duplicate symbols in
cmm tests, and probes.)

I have also checked that with Rosetta2 off,
make ci does not report any failure.

@gretay-js
Copy link
Contributor Author

@xclerc thanks for checking! do you agree that it's okay to delete rosetta related test helper files from simd tests directory?

@xclerc
Copy link
Contributor
xclerc commented Jun 25, 2025

Yes, I think it is. It vaguely remember it being
useful at the start of the Apple Silicon rollout
in GitHub CI, and I think I read somewhere
that Rosetta2 will be deprecated in about a year.

@gretay-js gretay-js merged commit 6c2e8e4 into oxcaml:main Jun 25, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheNumbat TheNumbat TheNumbat approved these changes

Assignees
No one assigned
Labels
simd SIMD support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gretay-js @mshinwell @xclerc @TheNumbat
0