Domainstate slots are unaligned #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
526fe07 to
fc1c733
Compare
mshinwell
approved these changes
Jun 24, 2025
xclerc
approved these changes
Jun 24, 2025
mshinwell
pushed a commit
that referenced
this pull request
Jun 25, 2025
* unaligned domainstate * fix calling conventions (cherry picked from commit 5f02144) (This commit only has the vec128 parts, not vec256/512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use aligned moves for SIMD regs with a
Stacklocation, but this also includesDomainstateslots, which may not be 16-aligned. Hence we should use an unaligned move in that case. Additionally,calling_conventionsshould not align the stack offset when it's negative, which indicates a domainstate slot. It was previously aligning down and assigning multiple values to the same slot.This fixes a crash in #4166