Remove caml_get_header_val, as not needed. #4189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stedolan
approved these changes
Jun 25, 2025
|
I think by the same reasoning, it would be more correct for |
|
Yes, also |
08e8bf3 to
567d6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arose during review of #3493 :
caml_get_header_valonly differs fromHd_valin that it will spin if it sees an in-progress header, i.e. if some domain is in the process of promoting the block. This can only happen between the barriers of a minor collection; there are very few places outsideminor_gc.cwhere it might be possible, and certainly not while updating finalizer data structures after a minor GC.