8000 Arrays accept any `separable` arguments, including non-float `or_null`s by dkalinichenko-js · Pull Request #4195 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Arrays accept any separable arguments, including non-float or_nulls #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: dkalinichenko/non-float-or-null
Choose a base branch
from
Draft

Arrays accept any separable arguments, including non-float or_nulls #4195

wants to merge 6 commits into from

Conversation

dkalinichenko-js
8000
Copy link
Collaborator
@dkalinichenko-js dkalinichenko-js commented Jun 25, 2025 •
edited
Loading

Remove the any_non_null layout. Instead, arrays now accept all any mod separable layouts, which included non-float or_nulls. Add tests for or_null arrays.

Prevent immediate_or_null arrays from being optimized to Intarray in Flambda. This should be fixed in a subsequent PR.

Non-value layouts are still Non_null to avoid issues with type inference defaulting to non-null sort variables in some places. Really, we should merge the nullability axis into the layout.

@dkalinichenko-js dkalinichenko-js added typing unboxed types or_null Related to or_null layouts labels Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
or_null Related to or_null layouts typing unboxed types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkalinichenko-js @d-kalinichenko
0