Remove with-bounds for polymorphic variants #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to have caused a performance regression, so we're just reverting it until we can investigate further.
ccasin
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
The diff to ctype is correct and the test diff looks like the one I expect. @glittershark please describe in a little more detail the relationship between this and #3845 in a comment or the PR description.
gretay-js
pushed a commit
that referenced
this pull request
Jun 26, 2025
This appears to have caused a performance regression, so we're just reverting it until we can investigate further.
glittershark
added a commit
that referenced
this pull request
Jun 26, 2025
This appears to have caused a performance regression, so we're just reverting it until we can investigate further.
goldfirere
added a commit
that referenced
this pull request
Jun 27, 2025
This reverts commit c2f257d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have caused a performance regression, so we're just reverting it until we can investigate further.