Aliases_of_canonical_element.invariant is a light invariant check #4191
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
approved these changes
Jun 25, 2025
|
@bclement-ocp pointed out that since we noticed it in the perf profiles, this was probably not a "light" invariant check. I've changed it to use |
mshinwell
pushed a commit
that referenced
this pull request
Jun 26, 2025
) * Aliases_of_canonical_element.invariant is a light invariant check * Not a light invariant (cherry picked from commit 4948e36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invariant checks for
Aliases.Aliases_of_canonical_elementwere run systematically. This PR makes them run only when light invariant checks are required.We noticed some compilations spending 15% of their time doing equality checks on patricia trees, which we suspect is due to this invariant check.