8000 Use proper equality comparison to avoid duplicating work by goldfirere · Pull Request #4209 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use proper equality comparison to avoid duplicating work #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Use proper equality comparison to avoid duplicating work #4209

wants to merge 4 commits into from

Conversation

goldfirere
Copy link
Collaborator

This fixes a terrible performance regression

glittershark
glittershark approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member
@glittershark glittershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second commit lgtm

@dkalinichenko-js
Copy link
Collaborator

Are we sure that Ctype.equal doesn't call Jkind.normalize and we avoid looping?

@goldfirere
Copy link
Collaborator Author

Are we sure that Ctype.equal doesn't call Jkind.normalize and we avoid looping?

Good question. But I think it's fine: Ctype.equal should call back into Jkind only for variables, which have r-kinds, which don't have with-bounds. (I checked the code on this point, but only briefly)

dkalinichenko-js
dkalinichenko-js reviewed Jun 26, 2025
View reviewed changes
@goldfirere goldfirere force-pushed the rae/fix-jkind-perf-regression branch from e2c290b to 1679889 Compare June 27, 2025 17:19
@ccasin
Copy link
Contributor
ccasin commented Jun 30, 2025

Testing on our codebase suggests this can cause compilation-time stack overflows, and will need further testing.

@goldfirere
Copy link
Collaborator Author

And doesn't actually improve performance to the degree necessary. Closing.

@goldfirere goldfirere closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glittershark glittershark glittershark approved these changes

@dkalinichenko-js dkalinichenko-js dkalinichenko-js left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goldfirere @dkalinichenko-js @ccasin @glittershark
0