fix(flambda2): Only check for unbound names in invariant #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `invariant_for_new_equation` in the typing env is supposed to check that the type we are adding only contains bound names, but it also includes checks for function slots and value slots that are never "bound" per se. Fix the check to only consider names instead.
lthls
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
invariant_for_new_equationin the typing env is supposed to check that the type we are adding only contains bound names, but it also includes checks for function slots and value slots that are never "bound" per se.Fix the check to only consider names instead.
(This makes the "heavy" invariants check not fail immediately when we add an equation with a closure type)