10000 fix(types): Do not call `TE.find` on imported variables in n-way join by bclement-ocp · Pull Request #4212 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): Do not call TE.find on imported variables in n-way join #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(types): Do not call TE.find on imported variables in n-way join #4212

wants to merge 1 commit into from
+74 −17

Conversation

bclement-ocp
Copy link
Contributor

The new join algorithm can fail with a "missing cmx and kind" error when creating a new existential variable that is equal in at least one of the branches to an imported variable for which we do not have type information.

This patch threads enough kind information to the places where this can occur, making sure that we only call TE.find with an unknown kind on variables that have been demoted and hence cannot have been imported from another compilation unit.

@bclement-ocp
fix(types): Do not call TE.find on imported variables in n-way join
8aab850 
The new join algorithm can fail with a "missing cmx and kind" error
when creating a new existential variable that is equal in at least one
of the branches to an imported variable for which we do not have type
information.

This patch threads enough kind information to the places where this can
occur, making sure that we only call `TE.find` with an unknown kind on
variables that have been demoted and hence cannot have been imported
from another compilation unit.
@bclement-ocp bclement-ocp requested a review from lthls June 27, 2025 09:10
@bclement-ocp bclement-ocp added bug Something isn't working flambda2 Prerequisite for, or part of, flambda2 labels Jun 27, 2025
lthls
lthls reviewed Jun 30, 2025
View reviewed changes
lthls
lthls approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@lthls lthls left a comment

Choose a reason for hiding this comment

The reason will be displaye 8C4C d to describe this comment to others. Learn more.

Looks ok for a temporary fix. Hopefully we can solve this for good by storing kinds on variables, before we hit the corner cases where kinds are missing.

@lthls lthls mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lthls lthls lthls approved these changes

Assignees
No one assigned
Labels
bug Something isn't working flambda2 Prerequisite for, or part of, flambda2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bclement-ocp @lthls
0