8000 Allow `float32` kind without the `small_numbers` extension. by TheNumbat · Pull Request #4227 · oxcaml/oxcaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow float32 kind without the small_numbers extension. #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Allow float32 kind without the small_numbers extension. #4227

merged 1 commit into from
Jun 30, 2025

Conversation

TheNumbat
Copy link
Member
@TheNumbat TheNumbat commented Jun 28, 2025 •
edited
Loading

Kinds are erasable, so it's ok to refer to the float32 kind without losing upstream compatibility. This makes library integration easier.

The small_numbers extension is still required to use float32 types and literals, so no code referring to float32 can exist after erasure.

@TheNumbat TheNumbat requested a review from ccasin June 28, 2025 02:42
@TheNumbat TheNumbat merged commit af3545f into main Jun 30, 2025
24 checks passed
@TheNumbat TheNumbat deleted the float32-layout-no-ext branch June 30, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccasin ccasin ccasin approved these changes

Assignees
No one assigned
Labels
unboxed types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheNumbat @ccasin
0