Change how extension level affects inferred modalities #4236
+31
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, inferred modalities are fixed to be identity if
modeextension is disabled. This causes some incompatibility between modules that hasmodeenabled and those not. For example, if we havea.mlthat hasmodeenabled, and we haveb.mlwithmodedisabled:and
b.mli:The later will have non-identity modalities while the former doesn't.
This is currently not testable, since with modules fixed at
legacy, the type checker simply copies the modalities fromAintoBwithout infering new modalities. But #3759 will be affected.The solution is to always infer modalties, but use extension level to control what the users can write and read.