Merge atomic counter inc/dec functions and use them consistently #3796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35d7f6a to
9efdb86
Compare
9efdb86 to
b2f0b9f
Compare
…aml#3644) Merge atomic counter inc/dec functions and use them consistently.
b2f0b9f to
60c4942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrects #3644 (reverted in #3781) with a very slight tweak to ensure that
#include "caml/misc.h"brings inatomic_uintnat. There's no particular reason to expect that it should, but it has done in the past and some code out there depends on it. There's now a circular dependency:misc.hgetsatomic_uintnatfromcamlatomic.handcamlatomic.hgetsCAMLassertfrommisc.h. Resolved by moving the#include "camlatomic.h"down into the guts ofmisc.h.In an ideal world we wouldn't have a file called
misc.h.