8000 linter(no-loss-of-precision): False Positive 1000000000000000128 · Issue #11436 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

linter(no-loss-of-precision): False Positive 1000000000000000128 #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
magic-akari opened this issue Jun 2, 2025 · 4 comments · Fixed by #11437
Closed

linter(no-loss-of-precision): False Positive 1000000000000000128 #11436

magic-akari opened this issue Jun 2, 2025 · 4 comments · Fixed by #11437
Assignees
@camc314

Comments

@magic-akari
Copy link
Contributor

OXC playground: https://playground.oxc.rs/#eNpVj9FqwzAMRX9l6KmFMJLCYOR55HVj+wLFUYrBsYIkdy0l/167IYH6xZKQzr33Dg5aODT162tOn8d3485faTjUxzeogKG9g6RYPr1Fwyu0JokqCD7aVqvjmfbmNvUcts4Eo44sE7QjBqWlghlFSQoRQ+D/X7Ik8TuZ+oG6FJ15znrr+SyUdy/0g0JR12lGFPEnIte7wso0lDNlZ0B6qpuPnMErBzQavsgFFCz4TNrcOB7oTM+AFLEP9MdJHE0472qTj370m57jaMKhy9bL0YWkZ83pV+CyPACwRHjd

eslint playground:
https://eslint.org/play/#eyJ0ZXh0IjoiLyplc2xpbnQgbm8tbG9zcy1vZi1wcmVjaXNpb246IFwiZXJyb3JcIiovXG5cbmNvbnN0IGEgPSAxMjM0NVxuY29uc3QgYiA9IDEyMy40NTZcbmNvbnN0IGMgPSAxMjNlMzRcbmNvbnN0IGQgPSAxMjMwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMFxuY29uc3QgZSA9IDB4MUZGRkZGRkZGRkZGRkZcbmNvbnN0IGYgPSA5MDA3MTk5MjU0NzQwOTkxXG5jb25zdCBnID0gOTAwN18xOTkyNTQ3NDA5XzkxXG5jb25zdCB4ID0gKDEwMDAwMDAwMDAwMDAwMDAxMjgpLnRvRml4ZWQoMCkiLCJvcHRpb25zIjp7InJ1bGVzIjp7fSwibGFuZ3VhZ2VPcHRpb25zIjp7InBhcnNlck9wdGlvbnMiOnsiZWNtYUZlYXR1cmVzIjp7fX19fX0=
@camc314 camc314 self-assigned this Jun 2, 2025
@camc314 camc314 mentioned this issue Jun 2, 2025
Closed
1 task
@camc314
Copy link
Contributor
camc314 commented Jun 2, 2025

I've filed an issue on the eslint side for this, as I believe oxlint is correctly reporting an error here.

Image

Furthermore I get a TS diagnostic when I put this number into my editor

Image

It looks like it's something related to that specific number in eslint? a digit less/more and the diagnostic is reported
8000

@camc314 camc314 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2025
@camc314
Copy link
Contributor
camc314 commented Jun 2, 2025

Also, how did you run into this case out of interest?

@magic-akari
Copy link
Contributor Author

I think the implementation in ESLint is correct. My example code includes toFixed; you can run it to verify.
I discovered this in a note within the ECMAScript Spec:
https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-number.prototype.tofixed

@camc314 camc314 reopened this Jun 2, 2025
@camc314
Copy link
Contributor
camc314 commented Jun 2, 2025

this feels very silly but basically the number gets coerced to 1000000000000000128 when performint operations on it?

> 1000000000000000120 - 1000000000000000128
0

@magic-akari magic-akari mentioned this issue Jun 2, 2025
Merged
camc314 pushed a commit that referenced this issue Jun 3, 2025
@magic-akari
fix(linter): improve eslint/no-loss-of-precision (#11437)
c77787c 
- Closes: #11436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camc314 camc314

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): improve eslint/no-loss-of-precision magic-akari/oxc
2 participants
@magic-akari @camc314
0