8000 fix(ast/estree): remove `TSImportTypeOptions` custom serializer by overlookmotel · Pull Request #10873 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ast/estree): remove TSImportTypeOptions custom serializer #10873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented May 7, 2025

Part of #9705.

TSImportTypeOptions custom serializer was to work around a bug in TS-ESLint parser. That bug has now been fixed, so we don't need this workaround any more.

typescript-eslint/typescript-eslint#11114

@github-actions github-actions bot added A-ast Area - 8000 AST C-bug Category - Bug labels May 7, 2025
Copy link
Contributor Author
overlookmotel commented May 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 7, 2025 15:40
Copy link
codspeed-hq bot commented May 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10873 will not alter performance

Comparing 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer (6f0638a) with main (5f15809)

Summary

✅ 36 untouched benchmarks

Copy link
Contributor
graphite-app bot commented May 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-07-test_ast_estree_bump_acorn-test262_ branch from c551be9 to e7a503c Compare May 7, 2025 15:57
graphite-app bot pushed a commit that referenced this pull request May 7, 2025
`TSImportTypeOptions` custom serializer was to work around a bug in TS-ESLint parser. That bug has now been fixed, so we don't need this workaround any more.

typescript-eslint/typescript-eslint#11114
@graphite-app graphite-app bot force-pushed the 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer branch from 2149748 to 010ae61 Compare May 7, 2025 15:58
Base automatically changed from 05-07-test_ast_estree_bump_acorn-test262_ to main May 7, 2025 16:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
`TSImportTypeOptions` custom serializer was to work around a bug in TS-ESLint parser. That bug has now been fixed, so we don't need this workaround any more.

typescript-eslint/typescript-eslint#11114
@overlookmotel overlookmotel force-pushed the 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer branch from 010ae61 to 6f0638a Compare May 7, 2025 16:37
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
@graphite-app graphite-app bot merged commit 6f0638a into main May 7, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-07-fix_ast_estree_remove_tsimporttypeoptions_custom_serializer branch May 7, 2025 16:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0