8000 test(ast/estree): bump `acorn-test262` dependency by overlookmotel · Pull Request #11449 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(ast/estree): bump acorn-test262 dependency #11449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

test(ast/estree): bump acorn-test262 dependency #11449

merged 1 commit into from
Jun 2, 2025
+3 −3

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Jun 2, 2025 •
edited
Loading

Bump acorn-test262 submodule, to integrate oxc-project/acorn-test262#44 and oxc-project/acorn-test262#45 which fix the field order in TS snapshots of TemplateElement and regexp Literals.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jun 2, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Jun 2, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review June 2, 2025 20:50
@overlookmotel overlookmotel mentioned this pull request Jun 2, 2025
Closed
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jun 2, 2025
@overlookmotel Graphite App
Copy link
Contributor Author
overlookmotel commented Jun 2, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 06-02-test_ast_estree_bump_acorn-test262_dependency branch from 91dce72 to 8d38c61 Compare June 2, 2025 21:10
graphite-app bot pushed a commit that referenced this pull request Jun 2, 2025
@overlookmotel
test(ast/estree): bump acorn-test262 dependency (#11449)
8d38c61 
Bump `acorn-test262` submodule, to integrate oxc-project/acorn-test262#44 and oxc-project/acorn-test262#45 which fix the field order in TS snapshots of `TemplateElement` and regexp `Literal`s.
@overlookmotel
test(ast/estree): bump acorn-test262 dependency (#11449)
bc41bdf 
Bump `acorn-test262` submodule, to integrate oxc-project/acorn-test262#44 and oxc-project/acorn-test262#45 which fix the field order in TS snapshots of `TemplateElement` and regexp `Literal`s.
@graphite-app graphite-app bot force-pushed the 06-02-test_ast_estree_bump_acorn-test262_dependency branch from 8d38c61 to bc41bdf Compare June 2, 2025 21:12
@graphite-app graphite-app bot merged commit bc41bdf into main Jun 2, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 06-02-test_ast_estree_bump_acorn-test262_dependency branch June 2, 2025 21:19
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 2, 2025
graphite-app bot pushed a commit that referenced this pull request Jun 2, 2025
@overlookmotel
test(ast/estree): conformance tests check field order in TS-ESTree AST (
7360bd2 
#11450)

ESTree conformance tests check field order is correct in TS-ESTree ASTs.

This revealed some mismatches, but they were fixed by #11449.

Need to skip 1 test which is only failing due to rounding errors in floating point numbers in the `serde_json` round-trip conversion JSON -> value -> JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel
0