8000 fix(parser): fix panic when parsing `export import` by Boshen · Pull Request #11473 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(parser): fix panic when parsing export import #11473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix(parser): fix panic when parsing export import #11473

merged 1 commit into from
Jun 4, 2025

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Jun 4, 2025

fixes #11453

@github-actions github-actions bot added the A-parser Area - Parser label Jun 4, 2025
@Boshen Graphite App
Copy link
Member Author
Boshen commented Jun 4, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Jun 4, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 4, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11473 will improve performances by 11.62%

Comparing 06-04-fix_parser_fix_panic_when_parsing_export_import_ (e291191) with main (7a5295d)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ mangler[cal.com.tsx] 3 ms 2.7 ms +11.62%

@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Jun 4, 2025 •
edited
Loading

Merge activity

@Boshen Boshen marked this pull request as draft June 4, 2025 08:09
@Boshen Boshen marked this pull request as ready for review June 4, 2025 08:47
@Boshen Boshen mentioned this pull request Jun 4, 2025
Merged
@graphite-app graphite-app bot force-pushed the 06-04-fix_parser_fix_panic_when_parsing_export_import_ branch from dab9723 to e291191 Compare June 4, 2025 09:00
@graphite-app graphite-app bot merged commit e291191 into main Jun 4, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 06-04-fix_parser_fix_panic_when_parsing_export_import_ branch June 4, 2025 09:06
@overlookmotel overlookmotel mentioned this pull request Jun 4, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Jun 4, 2025
@overlookmotel
test(ast/estree): remove test skip list for TS raw transfer tests (#1…
97aa9cc 
…1478)

There were some test cases we needed to skip because they'd cause parser to panic. That bug is now fixed (#11473), so no need to skip these tests any more.
@oxc-bot oxc-bot mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-parser Area - Parser C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parser: Crashes when encountering export import
1 participant
@Boshen
0