8000 feat(parser): produce syntax error for decorators on overload by Boshen · Pull Request #11496 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(parser): produce syntax error for decorators on overload #11496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

feat(parser): produce syntax error for decorators on overload #11496

merged 1 commit into from
Jun 5, 2025

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Jun 5, 2025

fixes #11029

class A {
    @decorator()
    method(): Array<string>
}

@Boshen Graphite App
Copy link
Member Author
Boshen commented Jun 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Jun 5, 2025
graphite-app[bot]
graphite-app bot reviewed Jun 5, 2025
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 5, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11496 will improve performances by 12.97%

Comparing 06-05-feat_parser_produce_syntax_error_for_decorators_on_overload (cd063d1) with main (510c1c6)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ mangler[cal.com.tsx] 3 ms 2.7 ms +12.97%

graphite-app[bot]
graphite-app bot reviewed Jun 5, 2025
View reviewed changes
@Boshen Boshen force-pushed the 06-05-feat_parser_produce_syntax_error_for_decorators_on_overload branch from d13b281 to 3a17e95 Compare June 5, 2025 10:27
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 5, 2025
@Boshen Boshen force-pushed the 06-05-feat_parser_produce_syntax_error_for_decorators_on_overload branch from 3a17e95 to b5f7548 Compare June 5, 2025 14:55
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 5, 2025
@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Jun 5, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 06-05-feat_parser_produce_syntax_error_for_decorators_on_overload branch from b5f7548 to cd063d1 Compare June 5, 2025 15:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 5, 2025
@graphite-app graphite-app bot merged commit cd063d1 into main Jun 5, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 06-05-feat_parser_produce_syntax_error_for_decorators_on_overload branch June 5, 2025 15:09
@oxc-bot oxc-bot mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees
No one assigned
Labels
A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A case playground rejects, but oxc-parser successful parsed
1 participant
@Boshen
0