8000 fix(minifier): fix incorrect span when performing collapse variable declarations by Boshen · Pull Request #11492 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(minifier): fix incorrect span when performing collapse variable declarations #11492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Jun 5, 2025

fixes rolldown/rolldown#4796

Incorrect span causes comments not being preserved.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Jun 5, 2025
Copy link
Member Author
Boshen commented Jun 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
codspeed-hq bot commented Jun 5, 2025

CodSpeed Instrumentation Performance Report

Merging #11492 will not alter performance

Comparing 06-05-fix_minifier_fix_incorrect_span_when_performing_collapse_variable_declarations (0d27e58) with main (ab0dd29)

Summary

✅ 38 untouched benchmarks

Copy link
Contributor
graphite-app bot commented Jun 5, 2025

Merge activity

…eclarations (#11492)

fixes rolldown/rolldown#4796

Incorrect span causes comments not being preserved.
@graphite-app graphite-app bot force-pushed the 06-05-fix_minifier_fix_incorrect_span_when_performing_collapse_variable_declarations branch from 3660e70 to 0d27e58 Compare June 5, 2025 04:27
@graphite-app graphite-app bot merged commit 0d27e58 into main Jun 5, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-05-fix_minifier_fix_incorrect_span_when_performing_collapse_variable_declarations branch June 5, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: legal comment not preserved when variable declarations are merged by minifier
1 participant
0