8000
github-actions
bot
added
the
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
label
Jun 10, 2025
overlookmotel
force-pushed
the
06-10-refactor_napi_move_raw_transfer_code_into_separate_directory
branch
from
June 11, 2025 11:21
overlookmotel
changed the title
refactor(napi): move raw transfer code into separate directory
refactor(napi/parser): move raw transfer code into separate directory
Jun 11, 2025
graphite-app
bot
force-pushed
the
06-10-refactor_napi_move_raw_transfer_code_into_separate_directory
branch
from
June 11, 2025 15:04
graphite-app
bot
deleted the
06-10-refactor_napi_move_raw_transfer_code_into_separate_directory
branch
June 11, 2025 15:10
refactor(napi/parser): move raw transfer code into separate directory #11583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fisker
reviewed
Jun 10, 2025
This was referenced Jun 10, 2025
11bd3b7 to
cd04b37
Compare
Merge activity
|
…#11583) Pure refactor. Move code for raw transfer into separate directory. This will enable exposing some internals to benchmarks without exposing them publicly from the package. Also lazy deserialization is going to add a lot more code - don't want `index.js` to get too bloated. Also make main entry point `index.js` run in strict mode (doesn't much matter, but it's good practice).
cd04b37 to
95ee174
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Add a fallback for `os.availableParallelism` in versions of NodeJS prior to v18.14.0, which don't support it. As requested by Prettier, who support NodeJS v14. #11583 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
S
2BD0
uggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move code for raw transfer into separate directory. This will enable exposing some internals to benchmarks without exposing them publicly from the package. Also lazy deserialization is going to add a lot more code - don't want
index.jsto get too bloated.Also make main entry point
index.jsrun in strict mode (doesn't much matter, but it's good practice).