8000 refactor(parser): rewrite decorator parsing by Boshen · Pull Request #11604 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(parser): rewrite decorator parsing #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

refactor(parser): rewrite decorator parsing #11604

merged 1 commit into from
Jun 11, 2025

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Jun 11, 2025 •
edited
Loading

fixes #11593

Parse decorators and pass them around explicitly instead of using a state to store them.

@github-actions github-actions bot added A-parser Area - Parser A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels 8000 Jun 11, 2025
@Boshen Graphite App
Copy link
Member Author
Boshen commented Jun 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the title chore(coverage): ignore .DS_Store refactor(parser): rewrite decorator parsing Jun 11, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 11, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11604 will not alter performance

Comparing 06-11-refactor_parser_rewrite_decorator_parsing (e9a8832) with main (4af58e0)

Summary

✅ 38 untouched benchmarks

@Boshen Boshen force-pushed the 06-11-refactor_parser_rewrite_decorator_parsing branch from 5d05847 to 7191556 Compare June 11, 2025 11:04
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 11, 2025
@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Jun 11, 2025 •
edited
Loading

Merge activity

@Boshen
refactor(parser): rewrite decorator parsing (#11604)
e9a8832 
fixes #11593

Parse decorators and pass them around explicitly instead of using a state to store them.
@graphite-app graphite-app bot force-pushed the 06-11-refactor_parser_rewrite_decorator_parsing branch from 7191556 to e9a8832 Compare June 11, 2025 11:12
@graphite-app graphite-app bot merged commit e9a8832 into main Jun 11, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 06-11-refactor_parser_rewrite_decorator_parsing branch June 11, 2025 11:18
@oxc-bot oxc-bot mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-codegen Area - Code Generation A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oxlint reports false positive "decorators are not valid" since v0.18.0
1 participant
@Boshen
0