8000 feat(parser): produce syntax error for `declare function foo() {}` by Boshen · Pull Request #11606 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(parser): produce syntax error for declare function foo() {} #11606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

feat(parser): produce syntax error for declare function foo() {} #11606

merged 1 commit into from
Jun 11, 2025
+44 −15

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Jun 11, 2025

closes #11590

@Boshen Boshen mentioned this pull request Jun 11, 2025
Merged
@Boshen Graphite App
8000 Copy link
Member Author
Boshen commented Jun 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Jun 11, 2025
graphite-app[bot]
graphite-app bot reviewed Jun 11, 2025
View reviewed changes
@Boshen Boshen force-pushed the 06-11-feat_parser_produce_syntax_error_for_declare_function_foo_ branch from 1a3c36c to 31e2faf Compare June 11, 2025 12:23
@Boshen Boshen requested a review from camc314 as a code owner June 11, 2025 12:23
@github-actions github-actions bot added the A-linter Area - Linter label Jun 11, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 11, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11606 will not alter performance

Comparing 06-11-feat_parser_produce_syntax_error_for_declare_function_foo_ (844a8a8) with main (b7b0dc3)

Summary

✅ 38 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 06-11-refactor_parser_improve_tsmoduledeclaration_parsing to graphite-base/11606 June 11, 2025 12:28
@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Jun 11, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/11606 to main June 11, 2025 12:34
@graphite-app graphite-app bot force-pushed the 06-11-feat_parser_produce_syntax_error_for_declare_function_foo_ branch from 31e2faf to 844a8a8 Compare June 11, 2025 12:35
@Boshen Boshen mentioned this pull request Jun 11, 2025
Merged
@graphite-app graphite-app bot merged commit 844a8a8 into main Jun 11, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 06-11-feat_parser_produce_syntax_error_for_declare_function_foo_ branch June 11, 2025 12:42
This was referenced Jun 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter A-parser Area - Parser C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid declare function foo() {}
2 participants
@Boshen @camc314
0