8000 refactor(parser): remove rewind in hot path for parsing `for (let` by camchenry · Pull Request #11623 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(parser): remove rewind in hot path for parsing for (let 8000 #11623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

refactor(parser): remove rewind in hot path for parsing for (let #11623

merged 1 commit into from
Jun 12, 2025

Conversation

camchenry
Copy link
Member

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 12, 2025
@camchenry camchenry mentioned this pull request Jun 12, 2025
Merged
@camchenry Graphite App
Copy link
Member Author
camchenry commented Jun 12, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry mentioned this pull request Jun 12, 2025
Merged
@graphite-app graphite-app bot changed the base branch from 06-11-refactor_parser_reduce_rewind_in_checking_if_start_of_function_type_or_constructor_type to graphite-base/11623 June 12, 2025 03:36
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 12, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11623 will not alter performance

Comparing 06-11-refactor_parser_remove_rewind_in_hot_path_for_parsing_for_let_ (4140bb8) with main (0f24366)

Summary

✅ 38 untouched benchmarks

@graphite-app graphite-app bot force-pushed the graphite-base/11623 branch from a855384 to 40b3a0e Compare June 12, 2025 03:43
@graphite-app graphite-app bot force-pushed the 06-11-refactor_parser_remove_rewind_in_hot_path_for_parsing_for_let_ branch from 0a19838 to 57d8a7d Compare June 12, 2025 03:43
@graphite-app graphite-app bot changed the base branch from graphite-base/11623 to main June 12, 2025 03:43
@graphite-app graphite-app bot force-pushed the 06-11-refactor_parser_remove_rewind_in_hot_path_for_parsing_for_let_ branch from 57d8a7d to 069c2b6 Compare June 12, 2025 03:43
@camchenry camchenry marked this pull request as ready for review June 12, 2025 03:46
@Boshen
Copy link
Member
Boshen commented Jun 12, 2025 •
edited
Loading

NICE! (There's a clippy warning.)

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 12, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented Jun 12, 2025 •
edited by graphite-app bot
Loading
8000

Merge activity

@graphite-app graphite-app bot force-pushed the 06-11-refactor_parser_remove_rewind_in_hot_path_for_parsing_for_let_ branch from 4f4b665 to 4140bb8 Compare June 12, 2025 04:46
@graphite-app graphite-app bot merged commit 4140bb8 into main Jun 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 06-11-refactor_parser_remove_rewind_in_hot_path_for_parsing_for_let_ branch June 12, 2025 04:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 12, 2025
@oxc-bot oxc-bot mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camchenry @Boshen
0