8000 fix(ast/estree): Fix `FormalParameter` by therewillbecode · Pull Request #9954 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ast/estree): Fix FormalParameter #9954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

fix(ast/estree): Fix FormalParameter #9954

merged 3 commits into from
Mar 21, 2025

Conversation

therewillbecode
Copy link
Contributor
@therewillbecode therewillbecode commented Mar 21, 2025 •
edited
Loading

Align our AST's ESTree output with that of TS-ESLint's for the FormalParameter node. Relates to #9705

Skips the estree serialization of accessibility readonly and overrides fields.

@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Mar 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 21, 2025
@therewillbecode therewillbecode force-pushed the fix/skip-es-tree-fields-on-formal-params branch from 67f1ed5 to 95d5607 Compare March 21, 2025 12:52
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Mar 21, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9954 will not alter performance

Comparing therewillbecode:fix/skip-es-tree-fields-on-formal-params (b897d72) with main (5ff50e6)

Summary

✅ 33 untouched benchmarks

overlookmotel
overlookmotel approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor
@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Mar 21, 2025

Merge activity

  • Mar 21, 9:09 AM EDT: @therewillbecode we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
@overlookmotel overlookmotel merged commit 6fcd342 into oxc-project:main Mar 21, 2025
24 checks passed
@oxc-bot oxc-bot mentioned this pull request Mar 23, 2025
Merged
@ArnaudBarre ArnaudBarre mentioned this pull request Mar 26, 2025
Closed
@therewillbecode therewillbecode deleted the fix/skip-es-tree-fields-on-formal-params branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therewillbecode @overlookmotel
0