Add a Header extractor for header parameters #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
May 15, 2025
|
|
||
| use super::{metadata::get_metadata, ExtractorMetadata, SharedExtractor}; | ||
|
|
||
| pub struct Header<HeaderType: DeserializeOwned + JsonSchema + Send + Sync> { |
There was a problem hiding this comment.
This is part of the public-facing API; it might be worth documenting (or including a small example)
smklein
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
from_mapcould be updated to be more elegant (it's basically the first Rust I ever wrote), but I think this will be fine in the meantime (and probably much longer).