8000 aarch64: add default image by TrappM · Pull Request #431 · oVirt/vdsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

aarch64: add default image #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

aarch64: add default image #431

merged 1 commit into from
Jun 4, 2025

Conversation

TrappM
Copy link
Contributor
@TrappM TrappM commented Jun 3, 2025

Add the 'generic virtual board model' for aarch64 support.

Currently there is no aarch64 board supported in vdsm/_DEFAULT_MACHINES and according to the qemu documentation
https://qemu-project.gitlab.io/qemu/system/arm/virt.html
'virt' seems to be the recommended generic board model for this platform.

@TrappM TrappM requested a review from mz-pdm as a code owner June 3, 2025 14:22
@dupondje
Copy link
Member
dupondje commented Jun 3, 2025

Hi,

Thanks for the PR.
Why do you want to add AARCH64 here? We don't have any support for it in the rest of the codebase, so (while it might be correct), this will never be used?

Next to that the commit also needs an Signed-off-by footer.

@TrappM
aarch64: add default image
7552c4b 
Add the 'generic virtual board model' for aarch64 support.

Signed-off-by: Michael Trapp <michael.trapp@sap.com>
@TrappM
Copy link
Contributor Author
TrappM commented Jun 4, 2025

Hi,

we are currently looking for aarch64 support in ovirt and this fix is required in the vdsm part of our setup,
because vdsm can't match the cpu architecture to an image.
There might be more changes required, like the feature/flag detection and 'model_*' labeling, but at the moment this is what we've fixed in vdsm and the virt model is sufficient for the qemu setup.

@dupondje
Copy link
Member
dupondje commented Jun 4, 2025

@TrappM : Thanks for the additional info!
Hope to see more patches coming :)

@dupondje dupondje merged commit 4127dfc into oVirt:master Jun 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mz-pdm mz-pdm Awaiting requested review from mz-pdm mz-pdm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrappM @dupondje
0