Fix tmpstorage teardown #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we moved to lvm devices, tmpstorage teardown is broken, and does
not deactivate and remove vgs during teardown. After running a test
creating a temporary loop device and creating a storage domain, the
storage domain lvs are left active:
$ sudo dmsetup table
bae261e2--3bfb--473d--86df--a63f92375df7-ids: 0 262144 linear 7:0 526336
bae261e2--3bfb--473d--86df--a63f92375df7-inbox: 0 262144 linear 7:0 788480
bae261e2--3bfb--473d--86df--a63f92375df7-leases: 0 4194304 linear 7:0 1312768
bae261e2--3bfb--473d--86df--a63f92375df7-master: 0 2097152 linear 7:0 7604224
bae261e2--3bfb--473d--86df--a63f92375df7-metadata: 0 262144 linear 7:0 264192
bae261e2--3bfb--473d--86df--a63f92375df7-outbox: 0 262144 linear 7:0 1050624
bae261e2--3bfb--473d--86df--a63f92375df7-xleases: 0 2097152 linear 7:0 5507072
cs-root: 0 94453760 linear 252:2 2048
cs-swap: 0 8298496 linear 252:2 94455808
and the loop device is not detached:
$ losetup -a
/dev/loop0: []: (/var/tmp/vdsm/test_merge_with_bitmap0/backing-file-000)
and the backing-file data is not deleted when deleting the backing file.
This quickly leads to filling the disk on the host running the tests.
The issue is using a lvm filter in tmpstorage; when using lvm devices,
the lvm filter is ignored, we don't find any vg, so we don't clean up
the lvm resources.
Fix by dropping the lvm config, and using --devices with all the devices
added to tmpstorage.
Tested by running lvm and blocksd tests on centos stream 8 host:
sudo ~/.venv/vdsm/bin/tox -e storage-root tests/storage/{lvm,blocksd}_test.py -- -v -m root
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
cbf41d9 to
8554f7f
Compare
aesteve-rh
approved these changes
Nov 21, 2022
mz-pdm
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved to lvm devices, tmpstorage teardown is broken, and does not deactivate and remove vgs during teardown. After running a test creating a temporary loop device and creating a storage domain, the storage domain lvs are left active:
and the loop device is not detached:
and the backing-file data is not deleted when deleting the backing file. This quickly leads to filling the disk on the host running the tests.
The issue is using a lvm filter in tmpstorage; when using lvm devices, the lvm filter is ignored, we don't find any vg, so we don't clean up the lvm resources.
Fix by dropping the lvm config, and using --devices with all the devices added to tmpstorage.
Tested by running lvm and blocksd tests on centos stream 8 host:
Signed-off-by: Nir Soffer nsoffer@redhat.com