resourceManager: use f-strings in exceptions #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
requested changes
Dec 7, 2022
2c2776f to
5a2e282
Compare
|
/ost |
1 similar comment
|
/ost |
Fix ResourceAlreadyAcquired raise to use f-string
instead of %-format. Also, the %-format is misued,
with a comma in between where the '%' symbol should
be, causing a bogus output.
Before:
vdsm.storage.resourceManager.ResourceAlreadyAcquired: ('%s is already
acquired by %s', '00_storage.a2ad7a23-96c5-4c23-9007-c0d1892ea07d',
'fb7c6873-74b4-4895-876a-a52ab7bfa082')
After:
vdsm.storage.resourceManager.ResourceAlreadyAcquired:
'00_storage.a2ad7a23-96c5-4c23-9007-c0d1892ea07d is already
acquired by fb7c6873-74b4-4895-876a-a52ab7bfa082'
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix ResourceDoesNotExist to be constructed with an f-string instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix NamespaceRegistered so that it is constructed with an fstring instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix InvalidNamespace to be constructed with an fstring instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix ValueError in resourceManager so that it is constructed with f-string instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix KeyError in resourceManager module so that it is constructed with f-string instead of using %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix InvalidLockType so that it is constructed with f-string instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Fix RequestTimedOutError so that it is constructed with fstring instead of %-format. Signed-off-by: Albert Esteve <aesteve@redhat.com>
5a2e282 to
161ae32
Compare
|
/ost |
nirs
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various exceptions in the resourceManager module, so that
it is constructed wiht f-string instead of %-format.
Fix
ResourceAlreadyAcquiredexception that isusing a comma to separate instead of
%, resulting inbogus printed message.
Before:
After:
Signed-off-by: Albert Esteve aesteve@redhat.com