-
Notifications
You must be signed in to change notification settings - Fork 159
Read the DNF config by module.py library #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
The DNF configuration has not been loaded when trying to get information about available module streams (library module.py). This causes a traceback e.g. on systems which must access DNF repositories via a proxy. This patch introduces loading the DNF configuration before trying to access remote resources. Jira: RHEL-39095
6b795f8
to
ae68e20
Compare
@@ -25,6 +25,8 @@ | |||
|
|||
8000 | def _get_package_repository_data_yum(): | ||
yum_base = yum.YumBase() | |||
# DNF configuration is not loaded here, since no impact for operations | |||
# done by the actor is observed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was meant for _get_package_repository_data_dnf()
function :) but that's a nitpick. no need to change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! we tested the fix manually previously. merging.
The DNF configuration has not been loaded when trying to get
information about available module streams (library module.py).
This causes a traceback e.g. on systems which must access DNF
repositories via a proxy.
This patch introduces loading the DNF configuration before trying
to access remote resources.
Jira: RHEL-39095