[ISS-3025] Allow removing of email from logs #3026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willwill96
commented
Apr 10, 2025
| package config | ||
|
|
||
| type Config struct { | ||
| maskSessionPII bool |
There was a problem hiding this comment.
Not sure if there is a better place to put this config. I initially tried putting this inside the logger package, however I ran into circular dependency issues when trying to import it from the session_state.go file
Comment on lines
+107
to
+111
| if config.GetMaskSessionPII() { | ||
| o = fmt.Sprintf("Session{user:%s", s.User) | ||
| } else { | ||
| o = fmt.Sprintf("Session{email:%s user:%s PreferredUsername:%s", s.Email, s.User, s.PreferredUsername) | ||
| } |
There was a problem hiding this comment.
I considered having email & preferredUsername hashed, so you could tell when there are identical values, but it feels like the user's id should be sufficient for that use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a configuration to remove PII from places where the session state is logged out.
Motivation and Context
Fixes #3025
How Has This Been Tested?
Against a locally running version of keycloak.
Checklist: