445 confirm redirect #566
Merged
445 confirm redirect #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skion
reviewed
Aug 13, 2018
| @@ -237,7 +237,6 @@ def test_unauthorized_client(self): | |||
|
|
|||
| def test_access_denied(self): | |||
| self.validator.authenticate_client.side_effect = self.set_client | |||
| self.validator.confirm_redirect_uri.return_value = False | |||
There was a problem hiding this comment.
I don't fully understand how this test is now passing without this line? Wasn't that line the purpose of the test?
There was a problem hiding this comment.
In the new flow, confirm_redirect_uri is not called because no redirect_uri is present in the request and get_default_redirect_uri return None.
But you are right that I replaced an initial intent with another use-case which didn't exist initially.
Let me fix that
| @@ -420,6 +420,17 @@ def validate_token_request(self, request): | |||
| # REQUIRED, if the "redirect_uri" parameter was included in the | |||
| # authorization request as described in Section 4.1.1, and their | |||
| # values MUST be identical. | |||
| if request.redirect_uri is None: | |||
| request.using_default_redirect_uri = True | |||
There was a problem hiding this comment.
I don't know. I was wondering it could be used in the Validator implementation. However, since it's not documented, maybe nobody care !
|
@skion : I have updated the changes, please feel free to review again and tell me :-) |
skion
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #445 for discussion