8000 OAuth2 `LegacyApplicationClient.prepare_request_body` now correctly uses the default `scope` provided in constructor by smarie · Pull Request #726 · oauthlib/oauthlib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2020
Merged

OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor #726

merged 4 commits into from
Apr 22, 2020

Conversation

smarie
Copy link
@smarie smarie commented Apr 9, 2020

Fixes #725

Sylvain MARIE added 3 commits April 9, 2020 10:53
@smarie smarie changed the title LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor Apr 9, 2020
@smarie smarie changed the title OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor Apr 9, 2020
@smarie
Copy link
Author
smarie commented Apr 9, 2020

Note: MobileApplicationClient and ServiceApplicationClient as well as WebApplicationClient seem to all have the same issue.

Do you want me to fix them as well ?

@smarie
Copy link
Author
smarie commented Apr 9, 2020 •
edited
Loading

(EDITED)

Really ? for one line of fix in each class ? It seems a bit overkill :)

I'll create just 1 other issue+PR for the three other classes at once.

And one for the base class as it seems to have issues as well.

@JonathanHuot JonathanHuot added this to the 3.1.1 milestone Apr 17, 2020
@JonathanHuot JonathanHuot added Bug OAuth2-Client This impact the client part of OAuth2. labels Apr 17, 2020
JonathanHuot
JonathanHuot approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member
@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@smarie
Copy link
Author
smarie commented Apr 19, 2020

Thanks for the review. I opened a new issue #728 and PR #729 for the other three classes, and will finally open another one for the base.

This was referenced Apr 19, 2020
Closed
Merged
@JonathanHuot JonathanHuot merged commit e255447 into oauthlib:master Apr 22, 2020
@smarie
Copy link
Author
smarie commented Apr 22, 2020

Thanks @JonathanHuot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanHuot JonathanHuot JonathanHuot approved these changes

Assignees
No one assigned
Labels
Bug OAuth2-Client This impact the client part of OAuth2.
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

OAuth2 LegacyApplicationClient should honor default scopes in prepare_request_body
2 participants
@smarie @JonathanHuot
0