fix: tavily/obot search: add time_range parameter #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
thedadams
approved these changes
May 9, 2025
tybalex
reviewed
May 9, 2025
search/tavily/main.py
Outdated
Comment on lines
56
to
76
| if time_range: | ||
| response = client.search( | ||
| query=query, | ||
| include_answer=os.getenv("INCLUDE_ANSWER", "").lower() | ||
| == "true", # no LLM-generated answer needed by default - we'll do that | ||
| include_raw_content=os.getenv("INCLUDE_RAW_CONTENT", "").lower() | ||
| != "false", # include raw content by default | ||
| max_results=max_results, | ||
| include_domains=include_domains, | ||
| time_range=time_range, | ||
| ) | ||
| else: | ||
| response = client.search( | ||
| query=query, | ||
| include_answer=os.getenv("INCLUDE_ANSWER", "").lower() | ||
| == "true", # no LLM-generated answer needed by default - we'll do that | ||
| include_raw_content=os.getenv("INCLUDE_RAW_CONTENT", "").lower() | ||
| != "false", # include raw content by default | ||
| max_results=max_results, | ||
| include_domains=include_domains, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if time_range: | |
| response = client.search( | |
| query=query, | |
| include_answer=os.getenv("INCLUDE_ANSWER", "").lower() | |
| == "true", # no LLM-generated answer needed by default - we'll do that | |
| include_raw_content=os.getenv("INCLUDE_RAW_CONTENT", "").lower() | |
| != "false", # include raw content by default | |
| max_results=max_results, | |
| include_domains=include_domains, | |
| time_range=time_range, | |
| ) | |
| else: | |
| response = client.search( | |
| query=query, | |
| include_answer=os.getenv("INCLUDE_ANSWER", "").lower() | |
| == "true", # no LLM-generated answer needed by default - we'll do that | |
| include_raw_content=os.getenv("INCLUDE_RAW_CONTENT", "").lower() | |
| != "false", # include raw content by default | |
| max_results=max_results, | |
| include_domains=include_domains, | |
| ) | |
| search_kwargs = { | |
| "query": query, | |
| "include_answer": os.getenv("INCLUDE_ANSWER", "").lower() == "true", | |
| "include_raw_content": os.getenv("INCLUDE_RAW_CONTENT", "").lower() != "false", | |
| "max_results": max_results, | |
| "include_domains": include_domains, | |
| } | |
| if time_range: | |
| search_kwargs["time_range"] = time_range | |
| response = client.search(**search_kwargs) |
tybalex
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for obot-platform/obot#2600
I hate marring such a beautifully simple, single-parameter tool by adding a second param, but there isn't another way that I know of to fix the issue I linked above.