Add tests of dependency on an alias #4238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #3415 ? |
|
@ejgallego, very much so! |
|
I didn't check all the details, but I'm surprised that the alias stamp doesn't depend on the trace of the rule attached to it, which is in principle what is used to see if the alias needs rebuild, right? |
5c56197 to
3f95d44
<
8000
span class="Button-label">Compare
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
2e9e88d to
cead050
Compare
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
|
I'm closing this PR in favor of #4303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user declares a dependency on an alias, the intention is to depend on the alias expansion.
Expansion is the idea we discussed in #2681 and it was generally agreed that the files mentioned in the
depsfield of an alias should contribute to its expansion.It turns out this is completely broken in Dune today: alias expansions only ever include the alias stamp files which is not what we want.
This PR fixes one source of the issue, while adding a test for the remaining issues.