Reduce interleaving between actions #4435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
This was referenced Apr 1, 2021
|
The action looks good to me, but to use it in a robust way, I wonder if we want a timeout mechanism. So either a timeout argument for this action, or something more general like a |
|
Where are you thinking to put a timeout? |
|
Something like |
|
Ah, I see. This way, if we accidentally break this test, we get a timeout rather than Dune b 8000 eing stuck forever. That makes sense. |
This was referenced Apr 26, 2021
|
@jeremiedimino I'm removing the 3.0 milestone. You can add it back if you plan to work on this. |
Repository owner
closed this by deleting the head repository
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion can
2A92
not be applied right now. Please check back later.
This PR adds a test showing that the output of different actions may be interleaved when they run several programs, and then changes this behavior.