Fix section in installed dune package #5404
Conversation
Signed-off-by: François Bobot <francois.bobot@cea.fr>
Keep the additional tests. Sections are added in the dune-package not only when dune-site is activated Signed-off-by: François Bobot <francois.bobot@cea.fr>
|
When is there more substitutions? |
|
I should not have used the term substitution. Replacement would be better. In the dune-package the local directory of the sections should be replaced by the installation destination for each section. All the sections of all the installed files are present. |
|
I don’t get what this is about. Aren’t the sections relative to the root directory of the package? |
|
If dune install should always be used, then all the opam packages in opam-repository would be wrong. Is that the case? |
|
What is the root directory of the package?
The problem appears only when using some advanced functionality, like dependency on file of a package. So it doesn't usually appear. When people will convert gradually to 3.0 and if they use the generated opam files, it will be solved. (EDIT: I must admit that I'm perhaps wrong with the place where the dune package in debian installs files (principally regarding |
| (lang dune <version>) | ||
| (name a) | ||
| (sections | ||
| (lib | ||
| $TESTCASE_ROOT/_build/install/default/lib/a) | ||
| $TESTCASE_ROOT/a/_build/install/default/lib/a) |
There was a problem hiding this comment.
I still don't see why are we using an absolute path here. We should be using a path relative to the dune-package file like we do every other path in dune-project.
There was a problem hiding this comment.
We can add the fix of #5394 in order to have relative path in _build/install, we can even have relative path in really installed dune-package (in opam switch or /usr). But in any case in really installed dune-package the path pointed must be the one where the files are installed, which is what this PR tackles.
|
@bobot do we still need this? |
|
No, I will close it. |
Fix for #5394
@kit-ty-kate it is a revert of #4861 because dune-package must be substituted not just when dune-sites is used