Add tests for diff printing logic #6196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37bd895 to
726d842
Compare
|
very puzzled by the output. this works locally and in an ubuntu docker container. |
bd4b586 to
dba4f15
Compare
e1d1a24 to
a26c10a
Compare
3611cfa to
b977079
Compare
This part of the logic is not tested; this adds some characterization tests to make sure we don't change that behavior accidentally. Signed-off-by: Etienne Millon <me@emillon.org>
b977079 to
3649bb0
Compare
|
@rgrinberg this is now ready. |
rgrinberg
approved these changes
Nov 3, 2022
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 4, 2022
* main: Add tests for diff printing logic (ocaml#6196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the logic is not tested; this adds some characterization tests to make sure we don't change that behavior accidentally.