Fix configurator MSVC invocations #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
|
Excellent! Thanks. LGTM. |
rgrinberg
approved these changes
Nov 21, 2022
rgrinberg
reviewed
Nov 21, 2022
CHANGES.md
Outdated
| @@ -22,6 +22,8 @@ Unreleased | |||
| - Remove "Entering Directory" messages for `$ dune install`. (#6513, | |||
| @rgrinberg) | |||
|
|
|||
| - Fix configurator when using the MSVC compiler (#6538, @nojb) | |||
There was a problem hiding this comment.
Should mention the bug this PR fixes.
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
added a commit
that referenced
this pull request
Dec 20, 2022
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Dec 21, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.2) CHANGES: - Fix configurator when using the MSVC compiler (ocaml/dune#6538, fixes ocaml/dune#6537, @nojb) - Fix running the RPC server on windows (ocaml/dune#6721 fixes ocaml/dune#6720, @rgrinberg)
jonahbeckford
pushed a commit
to diskuv/diskuv-opam-repository
that referenced
this pull request
Dec 23, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.2) CHANGES: - Fix configurator when using the MSVC compiler (ocaml/dune#6538, fixes ocaml/dune#6537, @nojb) - Fix running the RPC server on windows (ocaml/dune#6721 fixes ocaml/dune#6720, @rgrinberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MSVC, the output flag should be
-Fe<exe name>and-Fo<obj name>instead of-o <exe name>and-o <obj name>.Also removed some MSVC-specific logic that doesn't seem to be needed.
cc @jonahbeckford
Fixes #6537