8000 fix: add a dependency on current build run in `Source_tree.root` by jchavarri · Pull Request #7224 · ocaml/dune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add a dependency on current build run in Source_tree.root #7224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jchavarri
Copy link
Collaborator

Fixes #5549.

Adds a dependency on current build run in Source_tree.root. The fix was found by bisecting until I found the place where the parallelism in dune watch regressed (more details on original issue conversation). Hopefully the fix is correct, and someone with more knowledge can explain what the issue was, and why this fixes it 😅 Debugging and understanding memoization issues is not straightforward to me.

Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
@jchavarri
Copy link
Collaborator Author

Hm, one realization while testing this branch is that incremental builds in watch mode that would be almost instant before are way slower in the branch because dune has to re-create rules, etc. So the parallelization works again, but at the cost of having to recalculate a lot of things that were already calculated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dune build -w restricting job number for no reason
1 participant
0