8000 fix: sendfile: fall back to portable copy by emillon · Pull Request #8049 · ocaml/dune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: sendfile: fall back to portable copy #8049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: sendfile: fall back to portable copy #8049

merged 1 commit into from
Jun 27, 2023

Conversation

emillon
Copy link
Collaborator
@emillon emillon commented Jun 26, 2023 •
edited
Loading

Fixes #8041.

When using sendfile to copy files on Linux, fall back to the portable version if it fails at runtime for some reason (NFS, etc).

@emillon emillon mentioned this pull request Jun 26, 2023
Closed
16 tasks
@emillon emillon marked this pull request as ready for review June 26, 2023 12:38
@emillon emillon requested a review from rgrinberg June 26, 2023 12:38
@rgrinberg rgrinberg added this to the 3.9.0 milestone Jun 26, 2023
@emillon
fix: sendfile: fall back to portable copy
82732b8 
Fixes ocaml#8041

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon merged commit de45914 into ocaml:main Jun 27, 2023
@emillon emillon deleted the fix-8041 branch June 27, 2023 08:09
This was referenced Jun 27, 2023
Closed
Merged
emillon added a commit to emillon/dune that referenced this pull request Jun 27, 2023
@emillon
fix: sendfile: fall back to portable copy (ocaml#8049)
e61dbdd 
Fixes ocaml#8041

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Jun 27, 2023
@emillon
fix: sendfile: fall back to portable copy (ocaml#8049)
b23a45b 
Fixes ocaml#8041

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Jun 27, 2023
@emillon
fix: sendfile: fall back to portable copy (ocaml#8049)
a49c7ee 
Fixes ocaml#8041

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this pull request Jun 27, 2023
@emillon
[3.8] Backport #8049 (sendfile fix on Linux) (#8055)
82fcefb 
* test: add repro for #8041 (#8048)

Signed-off-by: Etienne Millon <me@emillon.org>

* fix: sendfile: fall back to portable copy (#8049)

Fixes #8041

Signed-off-by: Etienne Millon <me@emillon.org>

---------

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon mentioned this pull request Jun 27, 2023
Merged
emillon added a commit to emillon/opam-repository that referenced this pull request Jun 27, 2023
@emillon
[new release] dune (15 packages) (3.8.3)
eee509a 
CHANGES:

- Fix deadlock on Windows (ocaml/dune#8044, @nojb)

- When using `sendfile` to copy files on Linux, fall back to the portable
  version if it fails at runtime for some reason (NFS, etc).
  (ocaml/dune#8049, fixes ocaml/dune#8041, @emillon)
@alan-j-hu alan-j-hu mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrinberg rgrinberg rgrinberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

sendfile(): Invalid argument while installing
2 participants
@emillon @rgrinberg
0