feat: assembly implementation for blake3 #11914
Draft
+28,988
−2,901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c2b531 to
2e4f280
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Co-authored-by: Ali Caglayan <alizter@gmail.com> Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Previously, our copy function would attempt to insert both headers and directives whilst trying to copy. For assembly source files on Windows this would confuse the assembler. We fix this issue by separating the different kinds of copying functions and using the specific ones in each case. For assembly files we shouldn't be using any source modifying operations since platforms such as Windows are sensative to such changes. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we switch the blake3 implementation to use handwritten assembly. This offers a slight speedup in most cases.