ignore ENOTCONN errors on socket shutdown #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
reviewed
May 30, 2023
lib_eio_posix/low_level.ml
Outdated
| Fd.use_exn "shutdown" sock (fun fd -> Unix.shutdown fd cmd) | ||
| with | ||
| | Unix.Unix_error (Unix.ENOTCONN, _, _) -> () | ||
| | Unix.Unix_error (code, name, arg) -> raise @@ Err.wrap code name arg |
There was a problem hiding this comment.
Note: The idea was that the low-level functions in eio_posix raise Unix exceptions, with the wrapping done outside (in Flow.shutdown). So I think we should remove the last line here.
(However, this is inconsistent with eio_linux, which does wrap in its low-level module, and I see we do wrap in connect. And if we're going to catch exceptions then it would be more efficient to do it in one place.)
There was a problem hiding this comment.
Also, we should move the ENOTCONN handling to the high-level API. The low-level one should match the Unix module and raise the same exception it does.
macOS can return ENOTCONN occasionally even if the other side did a graceful shutdown. This changes all the backends to ignore ENOTCONN; even though it's unlikely to show up on Linux, there's still not much point throwing the exception from a shutdown on any of the platforms. Fixes ocaml-multicore#521
talex5
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS can return ENOTCONN occasionally even if the other side did a graceful shutdown. This changes all the backends to ignore ENOTCONN; even though it's unlikely to show up on Linux, there's still not much point throwing the exception from a shutdown on any of the platforms.
Fixes #521