Fix utop-eval-phrase on recent tuareg-mode #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuareg-next-phrase was moved to tuareg_indent.el in ocaml/tuareg@b40e733c1 and removed entirely in ocaml/tuareg@b2ad75f3d5 (September 2017). As a result, utop-eval-phrase crashes due to the missing function. Instead, write a small function to move to the next phrase, similar to the movement logic in tuareg-eval-phrase.
|
Thanks. cc @Chris00 here. I realize, that it was hard to predict this breakage, but it's good to be aware of things when they break. |
|
Perhaps we should also stop relying on the private functions from tuareg as well. |
|
Yep, that thought had crossed my mind. :) I'm not sure what a good alternative would be, but this gets it working in the meantime. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jul 15, 2018
CHANGES: * 4.07.0 compatibility (ocaml-community/utop#238, @hcarty) * Fix compatibility with latest tuareg-mode (ocaml-community/utop#241, @Wilfred) * Do not expand include directories (ocaml-community/utop#242, @sliquister)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tuareg-next-phrase was moved to tuareg_indent.el in
ocaml/tuareg@b40e733c1 and removed entirely in
ocaml/tuareg@b2ad75f3d5 (September 2017).
As a result, utop-eval-phrase crashes due to the missing function.
Instead, write a small function to move to the next phrase, similar to
the movement logic in tuareg-eval-phrase.