Update WinGet package as part of release workflow #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to look into how GitHub Apps work, and see if we can use that as a solution for the PAT. |
|
Until you get this working, I have an automation set up to run every 4 hours that checks if there is a new version available, that's not been added to the winget repo :) |
|
This will not work with a GitHub App, but I did just remember that @odamex-system exists. So that should work for what's needed here. |
f2c658d to
4894bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing WinGet package for Odamex, but it lags behind in updates by quite a bit. This PR is to make this package something officially maintained and updated as part of releases. When a new release is made, a PR is automatically made to https://github.com/microsoft/winget-pkgs with an updated manifest for the new version. Here is an example of such a PR: microsoft/winget-pkgs#248963 (note that once microsoft/winget-pkgs#243548 is merged, the new manifests created by this will be based on that one, rather than the 10.6.0 manifest that is currently the latest. This one properly indicates that Odamex is available for both x86 and x64, and allows installing per user or for all users)
For this to work, a fork of https://github.com/microsoft/winget-pkgs will need to be made under the odamex organization, and this repository will need a GitHub Personal Access Token (classic) with permissions set to
public_reposas a secret with the nameWINGET_TOKEN.If there is an odamex service account, the access token should probably be from that, rather than someones personal account.