handle Keep-Alive timeout log as DEBUG, not WARNING
#463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEBUG, not WARNINGDEBUG, not WARNING
|
WebSocket timeout should be logged as WANRING because this is the timeout of whole a WebSocket session and not reached when the session correctly finishes within the timeout. ( while Keep-Alive timeout should be DEBUG because it's per-read timeout and easily reached in any cases with no problem. ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session timeout very often happens in some clients such as browsers, and logs of them do not help anything in most cases.
Current Ohkami outputs these logs as
WARNSlog, so for browser, prints warning for almost every sessions! This will be only annoying in most situation.This PR changes session timeout logs to be
DEBUGones, output only whenDEBUGfeature is activated.