8000 Fix side nav icons error in Admin by KevinGhadyani-Okta · Pull Request #2461 · okta/odyssey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix side nav icons error in Admin #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 17, 2025
Merged

Fix side nav icons error in Admin #2461

merged 10 commits into from
Jan 17, 2025

Conversation

KevinGhadyani-Okta
Copy link
Contributor
@KevinGhadyani-Okta KevinGhadyani-Okta commented Jan 13, 2025 •
edited
Loading

https://oktainc.atlassian.net/browse/OKTA-850331

Summary

  1. To fix React context issues MUI icons, those icons are now bundled into the Odyssey UI Shell bundle. This allows them to be loaded in apps by passing a string rather than a React component.
  2. Updates SideNav with ErrorBoundary in case icons or anything else cause errors. Now, the whole side nav will stay visible even if a single nav entry fails. It's better for our users and will help with debugging, but will make it more difficult to identify issues.
  3. Fixes TopNav z-index issue.

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

image

@KevinGhadyani-Okta KevinGhadyani-Okta requested a review from a team as a code owner January 13, 2025 21:25
@KevinGhadyani-Okta KevinGhadyani-Okta changed the title Kg sidenav icons okta 850331 Fix side nav icons error in Admin Jan 13, 2025
@KevinGhadyani-Okta KevinGhadyani-Okta force-pushed the kg_sidenav-icons-OKTA-850331 branch from 5264d0c to add75b7 Compare January 13, 2025 21:43
@KevinGhadyani-Okta KevinGhadyani-Okta force-pushed the kg_sidenav-icons-OKTA-850331 branch from 51296fb to 6265506 Compare January 17, 2025 18:51
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit e5fb022 into main Jan 17, 2025
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the kg_sidenav-icons-OKTA-850331 branch January 17, 2025 21:49
benschell-okta
benschell-okta reviewed Jan 17, 2025
View reviewed changes
packages/odyssey-storybook/src/components/odyssey-labs/AppSwitcher/AppSwitcher.stories.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these stories move to the uishell portion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benschell-okta benschell-okta benschell-okta left review comments

@bryancunningham-okta bryancunningham-okta bryancunningham-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinGhadyani-Okta @benschell-okta @bryancunningham-okta
0