Add position customization ability for expand button in DataView - odyssey-react-mui #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapalmer-okta
approved these changes
May 29, 2025
| @@ -526,6 +531,7 @@ export const ExpandableRowsAndCards: Story = { | |||
| tableLayoutOptions={{ | |||
| columns: personColumns, | |||
| renderDetailPanel: renderAdditionalContent, | |||
| expandColumnPosition: 0, | |||
There was a problem hiding this comment.
Instead of modifying the existing story, do we have a separate test available for moving this expand column?
Also, wouldn't we only want it at left or right and not in the middle of the row?
Instead of an index, I'm thinking this would be better suited to a string identifier union "left" | "right" or "start" | "end" because we need it to work with right-to-left modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supporte
2D38
d.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-939446
Summary
What we did?
We've added a new customization option for the expand column button within the DataView component. Previously, the expand button's position was fixed at the beginning, limiting user control. This update introduces a new prop that allows developers to specify the desired column index for the expand button. By passing a number to this prop, the expand button will be placed among the regular data columns at the indicated position.
If no value is provided for this new prop, the component will default to its current behavior, ensuring no breaking changes.
Why we did this?
This modification was necessary to align with the specifications provided by our design team. This Figma design illustrates the expand button positioned as the second column.
Relevant slack thread discussing this problem.
Testing & Screenshots
(Our designer agrees to this change and the discussion with Odyssey team can be seen in the slack thread linked above.)