Enhance healthcheck failure handling and logging #4595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4595 +/- ##
==========================================
- Coverage 47.76% 47.74% -0.03%
==========================================
Files 370 370
Lines 29839 29855 +16
==========================================
Hits 14253 14253
- Misses 14479 14495 +16
Partials 1107 1107 |
maroshii
reviewed
Dec 2, 2024
aebf147 to
cce9ac7
Compare
ifbyol
reviewed
Dec 3, 2024
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
703f38b to
1293085
Compare
Signed-off-by: Teresa Romero <teresa@okteto.com>
teresaromero
commented
Dec 10, 2024
ifbyol
approved these changes
Dec 11, 2024
Signed-off-by: Teresa Romero <teresa@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes https://okteto.atlassian.net/browse/DEV-260
This PR proposes a change to show an information log whenever a readiness probe is failing and a service is waiting for being deployed.
It keeps the behaviour of returning an error when a liveness probe fails.
Refactors:
Events: detect the readiness and the liveness probe fail message and return new
Failureso the code can identify the origin.Pod probes detection: when readiness fails, log a message while waiting for being deployed, when livenes return error.
How to validate
Build the binary and configure different probes and healthchecks